Remove "root" node #341
Merged
Remove "root" node #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheerio uses a "root" object internally to collect parsed markup with multiple top-level nodes. This object is not itself a node, but modelling it as such can interfere with the parsing and traversing logic that Cheerio relies on. Attach the "root" object via an API that is not recognized by the traversal logic so that it is not exposed through querying operations.
|
sweeeeet. i've been wanting to get rid of that root node forever. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve issue #162. Note that I had to change some tests, but this was only necessary in those cases with explicit references to the
rootobject.Commit message: